Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@angular-devkit/build-angular): apply global CSS updates without a live-reload when using vite #25872

Merged
merged 1 commit into from Sep 20, 2023
Merged

feat(@angular-devkit/build-angular): apply global CSS updates without a live-reload when using vite #25872

merged 1 commit into from Sep 20, 2023

Conversation

alan-agius4
Copy link
Collaborator

This commit changes the way that global style updates are applied when using vite. When either live-reload or hmr are enabled the styles are replaced in placed (HMR style) without a live-reload.

@alan-agius4
feat(@angular-devkit/build-angular): apply global CSS updates without…
fb4023a 
… a live-reload when using `vite`

This commit changes the way that global style updates are applied when using `vite`.  When either live-reload or hmr are enabled the styles are replaced in placed (HMR style) without a live-reload.
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Sep 20, 2023
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Sep 20, 2023
@alan-agius4 alan-agius4 marked this pull request as ready for review September 20, 2023 12:51
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 20, 2023
@alan-agius4 alan-agius4 merged commit 8168ae2 into angular:main Sep 20, 2023
37 of 38 checks passed
@alan-agius4 alan-agius4 deleted the hmr-global-styles branch September 20, 2023 13:49
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alan-agius4 @clydin